X25519: standard requires masking of top bit#10713
Open
SparkiDev wants to merge 1 commit into
Open
Conversation
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10713
Scan targets checked: wolfcrypt-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src
Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
SparkiDev
force-pushed
the
curve25519_hibit_mask
branch
from
7fabda2 to
6d7fce3
Compare
Instead of failing when top bit is set, the standard and current research says to mask it. WOLFSSL_X25519_NO_MASK_PEER is added to allow the rejection when required.
SparkiDev
force-pushed
the
curve25519_hibit_mask
branch
from
6d7fce3 to
e017e6c
Compare
Contributor
Author
|
Jenkins: retest this please Agent offline |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Instead of failing when top bit is set, the standard and current research says to mask it.
WOLFSSL_X25519_NO_MASK_PEER is added to allow the rejection when required.
Fixes zd#3556
Testing
Ran standard tests.
./configure --disable-shared --enable-curve25519
./configure --disable-shared --enable-curve25519 CFLAGS=-DWOLFSSL_X25519_NO_MASK_PEER