fix: update debian/copyright to GPL-3+ and add missing attributions#10719
Open
MarkAtwood wants to merge 2 commits into
Open
fix: update debian/copyright to GPL-3+ and add missing attributions#10719MarkAtwood wants to merge 2 commits into
MarkAtwood wants to merge 2 commits into
Conversation
- wolfSSL license is GPL-3+, not GPL-2+ (matches COPYING) - camellia.c/h: NTT code is BSD-2-Clause, not GPL - Add missing blake2b.c/blake2s.c (CC0-1.0, Samuel Neves) - Add missing visibility.m4 (FSFAP, FSF) - Update copyright year range to 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Refresh Debian DEP-5 licensing metadata to align with upstream licensing and ensure all bundled third-party sources/macros are properly attributed.
Changes:
- Update primary package licensing from GPL-2+ to GPL-3+ and refresh wolfSSL copyright years.
- Add missing
Files:stanzas and license paragraphs for Camellia (NTT BSD-2-Clause), BLAKE2 (CC0-1.0), andm4/visibility.m4(FSFAP). - Normalize license identifiers / formatting (e.g., BSD-3-Clause, fixed email bracket), and extend
debian/*attribution.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
239
to
+248
| (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | ||
| OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
|
|
||
|
|
||
| License: Apache-2.0 | ||
| On modern Debian systems, the text of this license can be found | ||
| at: /usr/share/common-licenses/Apache-2.0 | ||
| On Debian systems, the complete text of the Apache License version 2.0 | ||
| can be found in "/usr/share/common-licenses/Apache-2.0". | ||
|
|
||
| License: FSFAP | ||
| Copying and distribution of this file, with or without modification, are | ||
| permitted in any medium without royalty provided the copyright notice |
Comment on lines
+12
to
+17
| Files: | ||
| wolfcrypt/src/camellia.c | ||
| wolfssl/wolfcrypt/camellia.h | ||
| Copyright: | ||
| 2006-2007 NTT (Nippon Telegraph and Telephone Corporation) | ||
| License: NTT-BSD-2-Clause |
MarkAtwood
requested review from
cconlon,
dgarske and
wolfSSL-Bot
and removed request for
dgarske
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
debian/copyrightfile was out of date in several ways:No code changes -- metadata only.
Test plan
lintianon built .deb shows noincorrect-source-licenseormissing-license-paragraphwarnings