Reader: Integrate ReaderPostHeaderView by kean · Pull Request #25465 · wordpress-mobile/WordPress-iOS

kean · 2026-03-27T17:47:59Z

This PR is part of CMM-1999: Reader: Adaptive Post Details Page. It integrates new ReaderPostHeaderView on the "Post Details" screen. I also made some minor tweaks to the design based on the feedback (see the screenshot for the latest version).

wpmobilebot · 2026-03-27T18:00:48Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Configuration	Release-Alpha
	Build Number	`32736`
	Version	`PR #25465`
	Bundle ID	`org.wordpress.alpha`
	Commit	`42e2e01`
	Installation URL	5qf23p2fnl3qg

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

wpmobilebot · 2026-03-27T18:00:51Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Configuration	Release-Alpha
	Build Number	`32736`
	Version	`PR #25465`
	Bundle ID	`com.jetpack.alpha`
	Commit	`42e2e01`
	Installation URL	3ocojjm07bc08

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

kean · 2026-03-30T19:31:11Z

+    /// beginning of the content — if the summary is just a prefix of the content
+    /// (optionally ending with `[…]` or `…`), it's considered auto-generated
+    /// and `nil` is returned.
+    func getUserProvidedExcerpt() -> String? {


This is a temporary implementation. I'm working with the backend folks to add a "raw_excerpt" field to the response to eliminate this code.

kean · 2026-03-30T19:32:34Z

+    ///   - text: The raw post content (may contain HTML/Markdown).
+    ///   - wpm: Words per minute reading speed (default 238).
+    /// - Returns: Estimated reading time in minutes (minimum 1).
+    public static func compute(_ text: String, wpm: Double = 200) -> Int {


This is WIP and subject to future changes. We need to see how well it works in practice.

dangermattic · 2026-04-02T14:26:53Z

	1 Warning
⚠️	This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

sonarqubecloud · 2026-04-02T15:22:55Z

Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

jkmassel

This is close, but we should probably address the latin issue and the author URL issue

jkmassel · 2026-04-10T19:09:32Z

+            totalSeconds += Double(max(12 - i, 3))
+        }
+
+        // 5. Code block penalty (extra half-speed cost for code)


Where is the extra half-speed cost factored in?

I believe this is where the "extra" comes from: totalSeconds at this point already counts whole text (clean), which includes the code blocks. This for-loop adds additional time to totalSeconds for reading code blocks.

jkmassel · 2026-04-10T19:12:55Z

+    @Test func codeBlocksAddPenalty() {
+        let base = String(repeating: "word ", count: 200)
+        let withCode = base + "```let x = 1; let y = 2; let z = 3```"
+        #expect(ReaderReadTime.compute(withCode) >= ReaderReadTime.compute(base))
+    }


This test should probably compare the same text with and without code fences delimiting code – otherwise you're just counting the extra words in withCode, I think?

Addressed in ce10352

jkmassel · 2026-04-10T19:14:37Z

+        let result = ReaderReadTime.compute(post)
+        #expect(result == 12)
+    }
+}


The following test would probably fail for posts with non-latin characters. It might be worth just detecting that we can't calculate a reading time for it and skipping that?

@Test func cjkTextProducesReasonableEstimate() { // ~500 CJK characters ≈ roughly 2-3 min read // CJK reading speed varies, but 500 characters should never be "1 min" let text = String(repeating: "这是一个测试句子用来验证阅读时间", count: 35) // ~500 chars #expect(ReaderReadTime.compute(text) > 1) }

Addressed in 00c35c5

jkmassel · 2026-04-10T19:33:09Z

+    init(post: ReaderPost) {
+        self.avatarURL = post.avatarURLForDisplay()
+        self.name = post.authorForDisplay() ?? ""
+        self.siteURL = post.blogURL.flatMap(URL.init(string:))


Above we use the author URL – should we do the same here? If someone is looking at a user profile, I'd imagine we'd want to show the site URL that the author has set, not the one for the site they're viewing?

The comment.author_url value is the site url, so these two init should display the same content. See the example below (The comment.author_url returns the wordpress.com URL for some reason).

Reader -> Header -> Avatar Reader -> Comments -> Avatar

wpmobilebot · 2026-05-25T02:21:07Z

Version 26.9 has now entered code-freeze, so the milestone of this PR has been updated to 27.0.

Co-authored-by: Jeremy Massel <1123407+jkmassel@users.noreply.github.com>

The reading-time estimator counted words via a whitespace-based regex, which collapsed an unbroken run of Chinese, Japanese, or Thai text into a single word and pinned the estimate at the one-minute floor. Count characters from those scripts separately and charge them per character at a rate derived from the words-per-minute speed, leaving space-delimited languages (including Korean) unchanged.

jkmassel · 2026-06-17T16:10:38Z

+    ///   - text: The raw post content (may contain HTML/Markdown).
+    ///   - wpm: Words per minute reading speed (default 200).
+    /// - Returns: Estimated reading time in minutes (minimum 1).
+    public static func compute(_ text: String, wpm: Double = 200) -> Int {


Is ViewModel.readingTime ever used by the header?

Given that the "reading time label" was prototyped but deleted in this PR, my guess is that the computation code is left over. I have deleted it in b962966.

jkmassel · 2026-06-17T16:10:38Z

+        result.append(
+            NSAttributedString(string: suffix, attributes: [
+                .font: font.withWeight(.regular),
+                .foregroundColor: UIColor.label,


Will this UIColor.label use the right reader theme colours?

jkmassel · 2026-06-17T16:10:38Z

-        delegate?.readerPostHeaderView(self, didTap: .featuredImage)
+    @objc private func excerptTapped() {
+        guard !isExcerptExpanded, let text = fullExcerptText else { return }
+        isExcerptExpanded = true


If the excerpt is expanded, then the reader theme is changed, does this update properly?

jkmassel · 2026-06-17T16:10:38Z

+        buttonSubscribe.addTarget(self, action: #selector(subscribeTapped), for: .touchUpInside)

        authorRow.isUserInteractionEnabled = true
        authorRow.addGestureRecognizer(UITapGestureRecognizer(target: self, action: #selector(authorTapped)))


There might be a VoiceOver regression here – the old header gave the author/site row .isButton + a “Views posts from the site” hint and we should probably do the same?

jkmassel · 2026-06-17T16:10:38Z

        }

+        if post.isFollowing {
+            header.buttonSubscribe.isHidden = true


If I follow a blog, I can't use this button to unsubscribe. Repro steps:

Follow a blog → post.isFollowing == true on its posts.

Open a post → render() hides the header button.

From the header: correct, you can’t unsubscribe — there’s no visible Subscribe/Subscribed control at all.

jkmassel · 2026-06-17T16:10:38Z

+
+        // If the content starts with the excerpt, it's auto-generated
+        let plainContent = content.makePlainText()
+        if plainContent.hasPrefix(excerpt.prefix(50)) {


prefix(50) drops legitimate author excerpts that restate the opening sentence (and any excerpt <50 chars that prefixes the body). Worst case is a hidden excerpt (graceful), but there's no test coverage — consider a real signal or at least pin the boundaries with tests.

jkmassel · 2026-06-17T16:10:38Z

+        case .siteName:
+            previewSite()
+        case .subscribe:
+                view.isShowingSubscribeLoadingIndicator = true


nit: indentation

jkmassel · 2026-06-17T16:10:38Z


-    func didTapFollowButton(completion: @escaping () -> Void) {
-        followSite(completion: completion)
+    private func showFeaturedImage(_ sender: AsyncImageView) {


We should probably have WPAnalytics.trackReader(.readerArticleImageTapped) fired on this?

jkmassel · 2026-06-17T17:00:11Z

+
+        // If the content starts with the excerpt, it's auto-generated
+        let plainContent = content.makePlainText()
+        if plainContent.hasPrefix(excerpt.prefix(50)) {


Concrete failing test for the prefix(50) problem above. It fails today — getUserProvidedExcerpt() returns nil and discards a real author excerpt whose first 50 chars match the body opening but then diverge.

Drop into a new Tests/KeystoneTests/Tests/Reader/ReaderPostExcerptTests.swift (XCTest + CoreDataTestCase, like the other Reader tests — it needs @testable import WordPress since the method is app-level):

import XCTest @testable import WordPress @testable import WordPressData final class ReaderPostExcerptTests: CoreDataTestCase { /// Author excerpt that opens with the post's first sentence, then diverges into /// its own teaser. `getUserProvidedExcerpt()` only compares `excerpt.prefix(50)` /// against the body, so it misclassifies this as auto-generated and drops it. /// /// Expected: the author's excerpt is returned. /// Actual (today): returns nil — this assertion fails. func testKeepsAuthorExcerptThatSharesOpeningSentenceButDiverges() { let excerpt = "We've been quietly rebuilding our sync engine for the past six months. Here's what it means for you." let post = ReaderPostBuilder(mainContext).build() post.content = "We've been quietly rebuilding our sync engine for the past six months. The new architecture replaces the legacy queue and halves battery use." post.mt_excerpt = excerpt XCTAssertEqual(post.getUserProvidedExcerpt(), excerpt) } }

(Left as a code block rather than a one-click suggestion because the test file isn't part of this diff — paste it into the new file.)

I think this is a not ideal but intentional solution. See this comment. The server side changes (see the linked Slack conversation in the comment) have not landed yet. Maybe we can improve this detection later?

jkmassel · 2026-06-17T17:03:59Z

+
+        // If the content starts with the excerpt, it's auto-generated
+        let plainContent = content.makePlainText()
+        if plainContent.hasPrefix(excerpt.prefix(50)) {


We should probably compare against the full excerpt instead of an excerpt of the excerpt?

Suggested change

if plainContent.hasPrefix(excerpt.prefix(50)) {

if plainContent.hasPrefix(excerpt) {

wpmobilebot · 2026-06-18T03:27:45Z

Version 27.0 has now entered code-freeze, so the milestone of this PR has been updated to 27.1.

…e-new-header-view

The new ReaderPostHeaderView no longer displays reading time, so the estimation that fed it (the computation, the cached string, and the view model field) was dead code. Remove it end to end.

Hiding the button whenever the post was already followed dead-ended its Subscribed state and left no way to unsubscribe from the header. Let it stay visible so it renders Subscribed and toggles the follow state on tap.

The truncated excerpt's view more suffix used UIColor.label, which ignored the reader theme and turned invisible in dark themes, so it now uses the themed foreground color. The author row is also exposed as an accessibility button with a combined label and a hint, restoring the VoiceOver affordance the previous header provided.

Fire readerArticleImageTapped when the header's featured image opens the lightbox, matching the tracking already done for in-content images and galleries. Also fixes the indentation of the subscribe case.

crazytonyli · 2026-06-22T08:31:24Z

@jkmassel Most of your comments have been addressed in the new commits.

kean added this to the 26.9 milestone Mar 27, 2026

kean added the Reader label Mar 27, 2026

kean force-pushed the task/reader-integrate-new-header-view branch from 7c5243b to 467612e Compare March 30, 2026 19:33

kean commented Apr 2, 2026

View reviewed changes

kean force-pushed the task/reader-integrate-new-header-view branch from 467612e to 0f34234 Compare April 2, 2026 14:26

kean force-pushed the task/reader-integrate-new-header-view branch from 0f34234 to c25e658 Compare April 2, 2026 15:19

kean requested a review from jkmassel April 2, 2026 15:19

kean changed the title ~~Integrate ReaderPostHeaderView~~ Reader: Integrate ReaderPostHeaderView Apr 6, 2026

kean force-pushed the task/reader-integrate-new-header-view branch 5 times, most recently from ee60136 to cf707c1 Compare April 7, 2026 16:35

jkmassel requested changes Apr 10, 2026

View reviewed changes

wpmobilebot modified the milestones: 26.9, 27.0 May 25, 2026

Base automatically changed from task/reader-reamove-featured-image-current to trunk May 26, 2026 00:37

Integrate ReaderPostHeaderView

0d2879f

crazytonyli force-pushed the task/reader-integrate-new-header-view branch from cf707c1 to 0d2879f Compare May 26, 2026 00:59

crazytonyli and others added 3 commits May 26, 2026 13:02

Fix a typo

f62f047

Co-authored-by: Jeremy Massel <1123407+jkmassel@users.noreply.github.com>

Update an unit test

ce10352

crazytonyli requested a review from jkmassel May 26, 2026 03:31

crazytonyli self-assigned this May 26, 2026

jkmassel requested changes Jun 17, 2026

View reviewed changes

wpmobilebot modified the milestones: 27.0, 27.1 Jun 18, 2026

crazytonyli added 5 commits June 22, 2026 14:23

Merge remote-tracking branch 'origin/trunk' into task/reader-integrat…

29c3f4f

…e-new-header-view

Remove unused reading time estimation from the Reader post header

b962966

The new ReaderPostHeaderView no longer displays reading time, so the estimation that fed it (the computation, the cached string, and the view model field) was dead code. Remove it end to end.

Keep the Reader header subscribe button visible for followed sites

e7675ce

Hiding the button whenever the post was already followed dead-ended its Subscribed state and left no way to unsubscribe from the header. Let it stay visible so it renders Subscribed and toggles the follow state on tap.

Track image taps on the Reader header featured image

42e2e01

Fire readerArticleImageTapped when the header's featured image opens the lightbox, matching the tracking already done for in-content images and galleries. Also fixes the indentation of the subscribe case.

crazytonyli requested a review from jkmassel June 22, 2026 08:31

	if plainContent.hasPrefix(excerpt.prefix(50)) {
	if plainContent.hasPrefix(excerpt) {

Uh oh!

Conversation

kean commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dangermattic commented Apr 2, 2026

Uh oh!

sonarqubecloud Bot commented Apr 2, 2026

Quality Gate passed

Uh oh!

jkmassel left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wpmobilebot commented May 25, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wpmobilebot commented Jun 18, 2026

Uh oh!

crazytonyli commented Jun 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kean commented Mar 27, 2026 •

edited

Loading

wpmobilebot commented Mar 27, 2026 •

edited

Loading

wpmobilebot commented Mar 27, 2026 •

edited

Loading