Stabilize Windows Behat failures in scaffold package/readme scenarios#294
Draft
Copilot wants to merge 4 commits into
Draft
Stabilize Windows Behat failures in scaffold package/readme scenarios#294Copilot wants to merge 4 commits into
Copilot wants to merge 4 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing Behat test job in GitHub Actions
Stabilize README Behat scenarios on Windows by avoiding package install side effects
Jun 9, 2026
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
Copilot
AI
changed the title
Stabilize README Behat scenarios on Windows by avoiding package install side effects
Stabilize README Behat scenarios on Windows by using package-readme fixtures
Jun 9, 2026
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
Copilot
AI
changed the title
Stabilize README Behat scenarios on Windows by using package-readme fixtures
Stabilize Windows Behat failures in scaffold package/readme scenarios
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failing Windows Behat job was caused by two separate issues:
--dirvalues expanded from~/...withHOMEset to an absolute Windows path.This PR stabilizes both paths while keeping the test intent focused.
Scope of change
scaffold package-readmescenarios infeatures/scaffold-package-readme.featureto:foo/composer.jsonfixture with the desiredwp-cli/wp-clirequirementwp scaffold package-readme foodirectlycomposer.jsonassertions in those scenarios to match fixture-based input/output.src/ScaffoldPackageCommand.phpso backslash-based paths (e.g.C:\...) are correctly treated as absolute and not incorrectly prefixed withcwd.Why this resolves the failure
package-readmefixtures removes fragile package-loading behavior from those tests.Targeted scenario update (example)