Enhance on-prem API key sync logic to support only RestApi#2216
Conversation
…kip unsupported kinds
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummaryThis PR updates API key synchronization for on-premises control planes by refining bulk API-key backfill to process only supported artifact kinds when running in on-prem mode. Changes
ImpactOn-prem deployments will backfill and reconcile API keys for supported kinds while consistently ignoring cloud-only kinds (e.g., LLM, WebSub, WebBroker) without stopping the overall bulk synchronization flow. Walkthrough
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain modules listed in go.work or their selected dependencies" Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai approve |
✅ Action performedComments resolved. Approval is disabled; enable |
This pull request updates the API key synchronization logic to support on-premises control planes more accurately. Specifically, it ensures that only supported artifact kinds (currently
RestApi) are considered for API key backfill when running in on-prem mode, while skipping unsupported kinds and logging the action.On-premises API key sync improvements:
onPremSupportedAPIKeyKindsmap to explicitly list artifact kinds (RestApi) for which the on-prem control plane exposes an API-key backfill endpoint, clarifying that other kinds (e.g., LLM, WebSub, WebBroker) are cloud-only.syncAPIKeysForExistingArtifactsmethod to skip unsupported kinds during bulk API key sync when running on-prem, logging a debug message for each skipped kind instead of skipping the entire sync process.Related to https://github.com/wso2-enterprise/wso2-apim-internal/issues/17413