🤖 Fix localized delete confirmations#1230
Open
rayhan206 wants to merge 1 commit into
Open
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1220.
What changed
This updates the event and organizer danger-zone delete confirmations so the typed confirmation is compared against the same localized
deletetranslation used by the input placeholder.That means translated confirmation words such as German
löschencan enable the delete button instead of requiring the English literaldelete.Validation
npm run build:csrpassesnpm run lintcurrently fails on existing repository-wide lint errors unrelated to this patchnpm run build-strict:csrcurrently fails on existing repository-wide TypeScript errors unrelated to this patchNotes
The same hardcoded confirmation pattern existed in both event deletion and organizer deletion, so both were updated for consistency.