Skip to content

🤖 Fix localized delete confirmations #1230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daveearley merged 1 commit into from
Jul 1, 2026
+6 −4
Merged

🤖 Fix localized delete confirmations #1230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions frontend/src/components/routes/event/Settings/Sections/DangerZoneSettings/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ export const DangerZoneSettings = () => {
const [deleteConfirmation, setDeleteConfirmation] = useState('');

const isArchived = event?.status === EventStatus.ARCHIVED;
const isDeleteConfirmed = deleteConfirmation.toLowerCase() === 'delete';
const deleteConfirmationPhrase = t`delete`;
const isDeleteConfirmed = deleteConfirmation.trim().toLocaleLowerCase() === deleteConfirmationPhrase.toLocaleLowerCase();

const handleDelete = () => {
const organizerId = event?.organizer?.id;
Expand Down Expand Up @@ -98,7 +99,7 @@ export const DangerZoneSettings = () => {
{t`Type "delete" to confirm`}
</Text>
<TextInput
placeholder={t`delete`}
placeholder={deleteConfirmationPhrase}
value={deleteConfirmation}
onChange={(e) => setDeleteConfirmation(e.currentTarget.value)}
/>
Expand Down
5 changes: 3 additions & 2 deletions frontend/src/components/routes/organizer/Settings/Sections/DangerZoneSettings/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ export const DangerZoneSettings = () => {
const [deleteConfirmation, setDeleteConfirmation] = useState('');

const isArchived = organizer?.status === OrganizerStatus.ARCHIVED;
const isDeleteConfirmed = deleteConfirmation.toLowerCase() === 'delete';
const deleteConfirmationPhrase = t`delete`;
const isDeleteConfirmed = deleteConfirmation.trim().toLocaleLowerCase() === deleteConfirmationPhrase.toLocaleLowerCase();

const activeOrganizerCount = organizers?.data?.filter(
org => org.status !== OrganizerStatus.ARCHIVED
Expand Down Expand Up @@ -104,7 +105,7 @@ export const DangerZoneSettings = () => {
{t`Type "delete" to confirm`}
</Text>
<TextInput
placeholder={t`delete`}
placeholder={deleteConfirmationPhrase}
value={deleteConfirmation}
onChange={(e) => setDeleteConfirmation(e.currentTarget.value)}
/>
Expand Down
Loading