Store DRep inline image data URI verbatim#3539
Draft
ArturWieczorek wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
test_register_and_retire_drep(thedrep_metadata_ipfs.jsonvariant, which uses aninline
data:image/png;base64,…image) asserts the DRep off-chain image the old way.cardano-db-sync #2138
(fixes #1966 stops stripping the
data:<mime>;base64,prefix: per CIP-119 it now storesthe full
contentUrlverbatim inoff_chain_vote_drep_data.image_url. The check indbsync_utils.check_off_chain_drep_registrationstill expected the stripped base64payload, so it fails against db-sync with
#2138.This updates the base64 branch to assert the full data URI (
image_url == content_url).Regular URL images (which carry a sha256) are unchanged.
The released
13.7.2.1binary does not contain #2138, and db-sync master still reportsversion
13.7.2.1, so the behavior can't be version-gated. After this merges,test_register_and_retire_drepwill fail against any db-sync without#2138- includingCI-nightly, which pins released
13.7.2.1. Merge alongside bumping the nightlyDBSYNC_REVto the release that includes#2138.Testing
To verify once a
#2138build exists:pytest -k "test_register_and_retire_drep" cardano_node_tests/tests/tests_conway/test_drep.py