Skip to content

Store DRep inline image data URI verbatim #3539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ArturWieczorek wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Store DRep inline image data URI verbatim #3539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions cardano_node_tests/utils/dbsync_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1332,8 +1332,6 @@ def check_off_chain_drep_registration( # noqa: C901
expected_metadata = metadata["body"]

# For the image rules refer to: https://cips.cardano.org/cip/CIP-0119
# off_chain_drep_data.image_url includes the image base64 with the data uri
# header prefix stripped and the off_chain_drep_data.image_sha256 remains empty.
def _check_image() -> None:
if "image" not in expected_metadata:
return
Expand All @@ -1349,10 +1347,10 @@ def _check_image() -> None:
"Invalid metadata: base64 encoded image should start with 'data:image/'"
)
if "base64" in content_url:
base64_image_data = content_url.split("base64,")[1]
if db_metadata.image_url != base64_image_data:
# db-sync stores the data URI verbatim (cardano-db-sync #2138).
if db_metadata.image_url != content_url:
errors.append(
"'image_url' value is different than expected Base64 'contentUrl';"
"'image_url' value is different than expected data-URI 'contentUrl';"
)
else:
errors.append("Invalid metadata: image is not Base64 encoded")
Expand Down
Loading