Skip to content

Add run v2 version toggle and default run path routing#2516

Merged
Mbeaulne merged 1 commit into
masterfrom
run-v2-version-toggle
Jul 15, 2026
Merged

Add run v2 version toggle and default run path routing#2516
Mbeaulne merged 1 commit into
masterfrom
run-v2-version-toggle

Conversation

@Mbeaulne

@Mbeaulne Mbeaulne commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Description

Adds a RunVersionToggle component to the app menu that lets users switch between the V1 and V2 run views, mirroring the existing EditorVersionToggle behaviour. When a user is on a V2 run page for the first time, a spotlight welcome dialog introduces the toggle.

A new runRoutes.ts module centralises run path construction via getRunPath and getDefaultRunPath. getDefaultRunPath automatically routes to the V2 run view when the v2_editor flag is enabled, and all previous inline APP_ROUTES.RUNS/${id} path constructions across RunRow, RerunPipelineButton, RunOverview, TangleSubmitter, and the Dashboard TypePill have been replaced with calls to this helper.

The v2_editor flag description has been updated to reflect that it now governs both the editor and the run view. The V2 run routes (/runs-v2/:id and /runs-v2/:id/:subgraphExecutionId) now redirect to their V1 equivalents when the flag is disabled.

EditorV2WelcomeSpotlight has been made generic so its title, description, ARIA label, and storage key behaviour can be reused for the run view welcome spotlight without duplication.

Related Issue and Pull requests

Type of Change

  • Bug fix
  • New feature
  • Improvement
  • Cleanup/Refactor
  • Breaking change
  • Documentation update

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

image.png

Test Instructions

  1. Enable the v2_editor flag in settings.
  2. Navigate to any run — confirm you are taken to /runs-v2/:id.
  3. Verify the RunVersionToggle button appears in the app menu and that clicking it switches between /runs/:id and /runs-v2/:id, preserving any subgraph execution segment.
  4. On first visit to a V2 run page, confirm the welcome spotlight appears and is dismissed by clicking "Got it" or clicking outside it. Confirm it does not reappear after dismissal.
  5. Disable the v2_editor flag and confirm that navigating directly to a /runs-v2/ URL redirects to the V1 equivalent, and that the toggle is hidden.

Additional Comments

The RunVersionToggle reuses EditorV2WelcomeSpotlight with custom props rather than duplicating the spotlight implementation. The seen-run-v2-welcome localStorage key tracks first-time spotlight dismissal independently of the editor welcome key.

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown

🎩 Preview

A preview build has been created at: run-v2-version-toggle/e82548f

@Mbeaulne
Mbeaulne marked this pull request as ready for review July 13, 2026 21:38
@Mbeaulne
Mbeaulne requested a review from a team as a code owner July 13, 2026 21:38
@Mbeaulne Mbeaulne changed the title Add Run V1 and V2 switching Add run v2 version toggle and default run path routing Jul 13, 2026
@Mbeaulne
Mbeaulne force-pushed the run-v2-version-toggle branch from 4a584c9 to 47cc96d Compare July 13, 2026 22:14
@Mbeaulne
Mbeaulne force-pushed the run-v2-tools-panel branch from 6182357 to 452ea66 Compare July 13, 2026 22:14
@Mbeaulne
Mbeaulne force-pushed the run-v2-version-toggle branch from 47cc96d to 67eba53 Compare July 13, 2026 22:25
@Mbeaulne
Mbeaulne force-pushed the run-v2-tools-panel branch from 452ea66 to 4b791c7 Compare July 13, 2026 22:25
Comment thread src/routes/v2/pages/RunView/RunViewV2.tsx
Comment thread src/components/shared/RunVersionToggle.tsx
Comment thread src/components/shared/EditorV2WelcomeSpotlight.tsx Outdated
Comment thread src/routes/router.ts

Mbeaulne commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator Author

Merge activity

  • Jul 15, 5:17 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 15, 5:28 PM UTC: Graphite rebased this pull request as part of a merge.
  • Jul 15, 5:31 PM UTC: @Mbeaulne merged this pull request with Graphite.

@Mbeaulne
Mbeaulne changed the base branch from run-v2-tools-panel to graphite-base/2516 July 15, 2026 17:22
@Mbeaulne
Mbeaulne changed the base branch from graphite-base/2516 to master July 15, 2026 17:26
@Mbeaulne
Mbeaulne force-pushed the run-v2-version-toggle branch from cc0ec78 to e82548f Compare July 15, 2026 17:27
@Mbeaulne
Mbeaulne merged commit d33d863 into master Jul 15, 2026
17 checks passed
@Mbeaulne
Mbeaulne deleted the run-v2-version-toggle branch July 15, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants