fix(glycin): disable jpegxl bcond and remove heif/jxl loader sources#17654
Open
WithEnoughCoffee wants to merge 2 commits into
Open
fix(glycin): disable jpegxl bcond and remove heif/jxl loader sources#17654WithEnoughCoffee wants to merge 2 commits into
WithEnoughCoffee wants to merge 2 commits into
Conversation
WithEnoughCoffee
requested review from
christopherco,
ddstreetmicrosoft and
reubeno
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Azure Linux glycin component to avoid Koji buildroot resolution failures by disabling the jpegxl bcond (in addition to heif) and ensuring Cargo buildrequires generation does not scan the glycin-heif / glycin-jxl workspace members.
Changes:
- Disable
jpegxlviabuild.withoutand propagate the resulting_without_jpegxlmacro into the rendered spec. - Remove
glycin-heifandglycin-jxlloader source directories in%prepwhen the corresponding bconds are disabled, preventing unresolvablecrate()BuildRequires. - Update rendered spec + lock fingerprint to match the component configuration changes.
Review notes (by severity):
- Errors (must-fix): The rendered spec changelog includes an rpmautospec “Local changes (uncommitted)” entry, which is a strong indicator the spec was rendered from a dirty tree and will likely fail the rendered-specs drift check in CI.
- Warnings (should-fix): The overlay uses
spec-search-replaceto inject new%preplines; aspec-append-linesoverlay would be more resilient to upstream changes. Also consider making the new removals tolerant of missing dirs (rm -rf/ guard) to avoid future build breaks if upstream layout changes.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
base/comps/glycin/glycin.comp.toml |
Adds jpegxl to build.without and injects a %prep overlay to remove heif/jxl loader directories. |
locks/glycin.lock |
Updates the component input fingerprint after config/overlay changes. |
specs/g/glycin/glycin.azl.macros |
Generated macros now include %_without_jpegxl 1 reflecting build.without. |
specs/g/glycin/glycin.spec |
Rendered spec reflects the new %prep removals and updated rpmautospec release/changelog. |
The glycin nightly build (Koji task 2584524) failed at buildroot resolution because: 1. jpegxl bcond was enabled, pulling pkgconfig(libjxl) — not in AZL4 2. %cargo_generate_buildrequires scanned all workspace members including glycin-heif, emitting crate(libheif-rs) deps — also unavailable Fix: add jpegxl to build.without list, and add an overlay to remove glycin-heif and glycin-jxl loader source dirs in %prep (same pattern as the existing glycin-raw/glycin-jpeg2000 removals). This prevents both the C-level and Rust crate-level BRs from being generated. Build verified: glycin-2.0.8-5.azl4 builds successfully with only glycin-image-rs and glycin-svg loaders. No heif/jxl deps in output RPMs. Ref: AB#20330
WithEnoughCoffee
force-pushed
the
fix/glycin-jpegxl-br
branch
from
0e25b89 to
a5e2d9e
Compare
This was referenced Jun 9, 2026
reubeno
requested changes
Jun 11, 2026
reubeno
left a comment
reubeno
left a comment
Member
There was a problem hiding this comment.
Changes generally look good, just 2 comments.
5 tasks
Move detailed context to PR description; remove closed work item reference. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
binujp
approved these changes
Jun 17, 2026
binujp
left a comment
binujp
left a comment
Contributor
There was a problem hiding this comment.
The change looks fine. Saw that you may not have done a koji build. Can you please do one to verify build closure holds? I will go ahead and approve this now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disables the
jpegxlbuild conditional and removesglycin-heif/glycin-jxlloader source directories in%prepto prevent unresolvable BuildRequires.Problem
Koji nightly build of glycin (task 2584524) fails at buildroot resolution (mock exit 30) due to two missing providers:
pkgconfig(libjxl) >= 0.11.0— thejpegxlbcond was enabled (since%rhelis undefined in AZL4)crate(libheif-rs)—%cargo_generate_buildrequires -ascans all workspace members includingglycin-heif, emitting Rust crate deps even though the meson build skips that loaderFix
"jpegxl"tobuild.without(alongside existing"heif") to gate the C-level BRglycin-heifandglycin-jxlloader source dirs in%prep, preventing cargo from generating crate BRs (same pattern as existingglycin-raw/glycin-jpeg2000removals)Validation
Build verified locally:
glycin-2.0.8-5.azl4builds successfully. Output RPMs contain onlyglycin-image-rsandglycin-svgloaders with no heif/jxl dependencies.Split out of AB#20330.