docs: add Netlify configuration for docs hosting migration #6930
docs: add Netlify configuration for docs hosting migration #6930harshitghagre wants to merge 5 commits into
Conversation
Ayushmore1214
left a comment
Ayushmore1214
left a comment
There was a problem hiding this comment.
@harshitghagre can we get some screenshots of this working ? I'm having some issue with it, I don't if its my env or the your code can you drop some outputs of this running, thanks!
thanks for review @Ayushmore1214 , you can test on this url https://pipecd-docs.netlify.app/ |
khanhtc1202
left a comment
khanhtc1202
left a comment
There was a problem hiding this comment.
Checked the testing link, it looks great. I left one comment on script update.
Also, why was the site on netlify doesn't contain the docs for v0.56.x?
| Run `make run/site` at the root directory of the repository and then access http://localhost:1313 | ||
| 1. Install dependencies: | ||
| ``` | ||
| cd docs && npm ci |
There was a problem hiding this comment.
Will this npm ci work? Since there is no script named ci in the docs/package.json
Also, do we really need to run a CI check (or whatever) every time I want to test the docs locally? It looks redundant to me.
Signed-off-by: harshitghagre <harshitghagre183@gmail.com>
3 participants
What this PR does:
Why we need it:
Which issue(s) this PR fixes:
Fixes #6801
Does this PR introduce a user-facing change?: