Skip to content

fix: drop orgId from group RPCs#1757

Merged
rohanchkrabrty merged 2 commits into
mainfrom
fix-remove-orgid-in-group-rpc-calls
Jul 15, 2026
Merged

fix: drop orgId from group RPCs#1757
rohanchkrabrty merged 2 commits into
mainfrom
fix-remove-orgid-in-group-rpc-calls

Conversation

@rohanchkrabrty

Copy link
Copy Markdown
Contributor

Summary

  • Bumped @raystack/proton to the latest (0.1.0-f0b06e61...) in both web/sdk and web/apps/admin so the SDK regenerates without org_id on the affected group RPCs.
  • Removed the now-invalid orgId argument from getGroup, updateGroup, listGroupUsers, removeGroupUser, deleteGroup, and setGroupMemberRole calls across the team views.
  • Left ListOrganizationGroups and ListCurrentUserGroups untouched — they still take org_id.
  • Verified the full pnpm build (SDK + admin) passes against the regenerated SDK types with no new type errors.

The backend removed org_id from GetGroup, UpdateGroup, ListGroupUsers,
RemoveGroupUser, DeleteGroup, and SetGroupMemberRole. Bump @raystack/proton
to the latest so the SDK regenerates without those fields, and remove the
now-invalid orgId args from the team views.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@vercel

vercel Bot commented Jul 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview, Comment Jul 14, 2026 10:07am

@rohanchkrabrty rohanchkrabrty changed the title fix(teams): drop orgId from group RPCs and bump proton fix(teams): drop orgId from group RPCs Jul 14, 2026
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@rohanchkrabrty, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 36 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: fe1c347f-281e-40ce-9950-6bac982ef779

📥 Commits

Reviewing files that changed from the base of the PR and between dab6e85 and 8631db1.

⛔ Files ignored due to path filters (1)
  • web/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (6)
  • web/sdk/client/views/teams/components/add-member-menu.tsx
  • web/sdk/client/views/teams/components/delete-team-dialog.tsx
  • web/sdk/client/views/teams/components/edit-team-dialog.tsx
  • web/sdk/client/views/teams/components/remove-member-dialog.tsx
  • web/sdk/client/views/teams/team-details-view.tsx
  • web/sdk/package.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coveralls

coveralls commented Jul 14, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 29324173132

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Warning

No base build found for commit dab6e85 on main.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 44.876%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 37644
Covered Lines: 16893
Line Coverage: 44.88%
Coverage Strength: 12.54 hits per line

💛 - Coveralls

@rohanchkrabrty rohanchkrabrty changed the title fix(teams): drop orgId from group RPCs fix: drop orgId from group RPCs Jul 14, 2026
Comment thread web/sdk/client/views/teams/team-details-view.tsx
Comment thread web/sdk/client/views/teams/team-details-view.tsx
@rohanchkrabrty rohanchkrabrty requested a review from Shreyag02 July 15, 2026 07:51
@rohanchkrabrty rohanchkrabrty merged commit ab3fce9 into main Jul 15, 2026
8 checks passed
@rohanchkrabrty rohanchkrabrty deleted the fix-remove-orgid-in-group-rpc-calls branch July 15, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants