Skip to content

fix: drop orgId from group RPCs #1757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rohanchkrabrty merged 2 commits into from
Jul 15, 2026
Merged

fix: drop orgId from group RPCs #1757

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c969c55
fix(teams): drop orgId from group RPCs and bump proton
rohanchkrabrty Jul 14, 2026
8631db1
chore: revert admin proton bump
rohanchkrabrty Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions web/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion web/sdk/client/views/teams/components/add-member-menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,6 @@ export function AddMemberMenu({
setGroupMemberRole(
create(SetGroupMemberRoleRequestSchema, {
groupId: teamId,
orgId: organization.id,
principalId: userId,
principalType: PERMISSIONS.UserPrincipal,
roleId: memberRoleId
Expand Down
3 changes: 1 addition & 2 deletions web/sdk/client/views/teams/components/delete-team-dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,7 @@ export function DeleteTeamDialog({ handle, refetch }: DeleteTeamDialogProps) {
try {
await deleteTeam(
create(DeleteGroupRequestSchema, {
id: teamId,
orgId: organization.id
id: teamId
})
);
toastManager.add({ title: 'Team deleted', type: 'success' });
Expand Down
1 change: 0 additions & 1 deletion web/sdk/client/views/teams/components/edit-team-dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@ function EditTeamForm({ payload, handle, refetch }: EditTeamFormProps) {
await updateTeam(
create(UpdateGroupRequestSchema, {
id: payload.teamId,
orgId: organization.id,
body: {
title: data.title,
name: payload.name
Expand Down
1 change: 0 additions & 1 deletion web/sdk/client/views/teams/components/remove-member-dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ function RemoveMemberForm({
await removeGroupUser(
create(RemoveGroupUserRequestSchema, {
id: payload.teamId,
orgId: organization.id,
userId: payload.memberId
})
);
Expand Down
7 changes: 2 additions & 5 deletions web/sdk/client/views/teams/team-details-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,7 @@ export function TeamDetailsView({
} = useQuery(
FrontierServiceQueries.getGroup,
create(GetGroupRequestSchema, {
id: teamId || '',
orgId: organization?.id || ''
id: teamId || ''
}),
{
enabled: !!organization?.id && !!teamId,
Comment thread
Shreyag02 marked this conversation as resolved.
Expand All @@ -114,8 +113,7 @@ export function TeamDetailsView({
} = useQuery(
FrontierServiceQueries.listGroupUsers,
create(ListGroupUsersRequestSchema, {
id: teamId || '',
orgId: organization?.id || ''
id: teamId || ''
}),
{ enabled: !!organization?.id && !!teamId }
Comment thread
Shreyag02 marked this conversation as resolved.
);
Expand Down Expand Up @@ -214,7 +212,6 @@ export function TeamDetailsView({
await setGroupMemberRole(
create(SetGroupMemberRoleRequestSchema, {
groupId: teamId,
orgId: organization.id,
principalId: memberId,
principalType: PERMISSIONS.UserPrincipal,
roleId: role.id as string
Expand Down
2 changes: 1 addition & 1 deletion web/sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@
"@connectrpc/connect-query": "2.1.1",
"@connectrpc/connect-web": "2.1.1",
"@hookform/resolvers": "^3.10.0",
"@raystack/proton": "0.1.0-859ba765e6cfd44736ddcf42664b742fe7fd916e",
"@raystack/proton": "0.1.0-f0b06e61f1985a9052f32744976a2b73d8c56839",
"@tanstack/react-query": "^5.90.2",
"@tanstack/react-router": "^1.168.3",
"axios": "^1.9.0",
Expand Down
Loading