Configure.ac updates#10712
Open
kareem-wolfssl wants to merge 3 commits into
Open
Conversation
Thanks to NVIDIA Project Vanessa for the report.
… by default in lighttpd. Fixes wolfSSL#10679.
…s is currently unsupported and will fail. Fixes wolfSSL#10690.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates configure.ac to improve autotools configuration behavior for specific feature sets and host targets, addressing reported build/configuration issues (notably Lighttpd defaults and x86_64 MinGW SP-ASM selection), and adds a guard around eval-based path expansion.
Changes:
- Auto-enables
--enable-curve25519when--enable-lightyis selected (and not in FIPS mode). - Rejects (or disables with a warning)
--enable-sp-asmon x86_64 Windows-like autotools hosts (MinGW/Cygwin/MSYS) to avoid assembler failures. - Adds validation intended to prevent command execution via
--libdir/--includedirvalues beforeevalexpansion.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+12514
to
+12523
| # The eval calls below expand ${prefix}/${exec_prefix} references embedded in | ||
| # the libdir/includedir values. eval would, however, also execute any shell | ||
| # command substitution contained in a --libdir/--includedir value (e.g. | ||
| # --libdir='$(cmd)/lib'), running arbitrary commands during configure. | ||
| # Reject values that contain command substitution before the eval. | ||
| case "$libdir $includedir" in | ||
| *'`'* | *'$('*) | ||
| AC_MSG_ERROR([--libdir and --includedir must not contain shell command substitution]) | ||
| ;; | ||
| esac |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes zd#21992 report 24, #10690, #10679
Testing
Generated and tested configure manually + Built in tests
Checklist